fix(resharding): MissingTrieValue in tests #12677
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Trisfald
reviewed
Jan 2, 2025
Trisfald
reviewed
Jan 2, 2025
Trisfald
reviewed
Jan 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially applies the patch: #12597
It was failing for delayed receipt tests with
MissingTrieValue(TrieStorage)insidecheck_state_shard_uid_mapping_after_resharding.The reason is that trie access interface returns
Nonefor a key with an empty value (which is the case for delayed receipts and negative refcounts).That was not caught up before the patch, because the
check_state_shard_uid_mapping_after_reshardingwas called after resharding, but not in the end of the test (after gc kicked in).Changes
This PR modifies the
check_state_shard_uid_mapping_after_reshardingto not check entries with negative refcount.The test is refactored so that the main loop does not finish an epoch after resharding, but keeps running until gc kicks in.
For that, the code responsible for testing temporary account is moved to a loop action,
and all loop actions are moved to a separate file for readability.
Note
test_resharding_v3_yield_resumeis still failing with the original patch: #12597