Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[epoch] Move EpochInfoAggregator to core/primitives #12855

Merged
merged 5 commits into from
Jan 31, 2025

Conversation

shreyan-gupta
Copy link
Contributor

This is required for a new epoch store adapter.

@shreyan-gupta shreyan-gupta requested a review from a team as a code owner January 31, 2025 17:02
Copy link

codecov bot commented Jan 31, 2025

Codecov Report

Attention: Patch coverage is 90.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 70.41%. Comparing base (fb3c0cc) to head (cbec01e).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
chain/epoch-manager/src/lib.rs 81.81% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #12855      +/-   ##
==========================================
- Coverage   70.42%   70.41%   -0.01%     
==========================================
  Files         853      853              
  Lines      174114   174093      -21     
  Branches   174114   174093      -21     
==========================================
- Hits       122614   122585      -29     
- Misses      46284    46290       +6     
- Partials     5216     5218       +2     
Flag Coverage Δ
backward-compatibility 0.35% <0.00%> (+<0.01%) ⬆️
db-migration 0.35% <0.00%> (+<0.01%) ⬆️
genesis-check 1.41% <0.00%> (+<0.01%) ⬆️
linux 70.09% <65.00%> (+0.01%) ⬆️
linux-nightly 70.03% <90.00%> (-0.03%) ⬇️
pytests 1.72% <0.00%> (+<0.01%) ⬆️
sanity-checks 1.52% <0.00%> (+<0.01%) ⬆️
unittests 70.23% <90.00%> (-0.01%) ⬇️
upgradability 0.35% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@pugachAG pugachAG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but as far as I understand primitives mostly contains data structs, so doesn't seem like EpochInfoAggregator belongs there, maybe move it somewhere to store/utils?

@shreyan-gupta
Copy link
Contributor Author

LGTM, but as far as I understand primitives mostly contains data structs, so doesn't seem like EpochInfoAggregator belongs there, maybe move it somewhere to store/utils?

Yes, you're right. This shouldn't be part of primitives. I'm not sure whether I should move it to store/util/ or store/epoch/ or just store/epoch_info_aggregator.rs

@pugachAG
Copy link
Contributor

@shreyan-gupta probably just store/epoch_info_aggregator.rs is good enough for now, later we can consider moving some of the files from store/ into subdirectories as part of a separate effort

@shreyan-gupta shreyan-gupta added this pull request to the merge queue Jan 31, 2025
Merged via the queue into master with commit b1bb76c Jan 31, 2025
29 checks passed
@shreyan-gupta shreyan-gupta deleted the shreyan/epoch/info_aggregator branch January 31, 2025 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants