-
Notifications
You must be signed in to change notification settings - Fork 674
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[epoch] Move EpochInfoAggregator to core/primitives #12855
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #12855 +/- ##
==========================================
- Coverage 70.42% 70.41% -0.01%
==========================================
Files 853 853
Lines 174114 174093 -21
Branches 174114 174093 -21
==========================================
- Hits 122614 122585 -29
- Misses 46284 46290 +6
- Partials 5216 5218 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but as far as I understand primitives mostly contains data structs, so doesn't seem like EpochInfoAggregator
belongs there, maybe move it somewhere to store/utils?
Yes, you're right. This shouldn't be part of primitives. I'm not sure whether I should move it to store/util/ or store/epoch/ or just store/epoch_info_aggregator.rs |
@shreyan-gupta probably just |
This is required for a new epoch store adapter.