Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow expiresIn to be a string #376

Merged
merged 2 commits into from
Sep 18, 2023
Merged

Allow expiresIn to be a string #376

merged 2 commits into from
Sep 18, 2023

Conversation

felixmosh
Copy link
Contributor

@felixmosh felixmosh commented Sep 18, 2023 •
edited
Loading

closes #377

@simoneb
Copy link
Member

simoneb commented Sep 18, 2023

Thanks, indeed we forgot to do this change in #364

@simoneb
Copy link
Member

simoneb commented Sep 18, 2023

@felixmosh would you mind adding a test for this in https://github.com/nearform/fast-jwt/blob/master/test/types.spec.ts so we prevent a regression?

@felixmosh
Copy link
Contributor Author

Sure :]

@simoneb
Copy link
Member

simoneb commented Sep 18, 2023

can you also please rebase on master? I removed support for Node 14 which is failing the build

@simoneb simoneb merged commit 7b3d317 into nearform:master Sep 18, 2023
6 checks passed
@github-actions github-actions bot mentioned this pull request Sep 20, 2023
Closed
@optic-release-automation optic-release-automation bot mentioned this pull request Sep 21, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simoneb simoneb simoneb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[type] expriesIn can be a string
2 participants
@felixmosh @simoneb