-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sync docker files with what is deployed to ja.quansight.dev #109
Conversation
jupyterhub/environment.yaml
Outdated
@@ -14,4 +14,4 @@ dependencies: | |||
- pip: | |||
- nebari-jupyterhub-theme | |||
- python-keycloak==0.26.1 | |||
- jhub-apps==2024.1.2 | |||
- jhub-apps==2024.1.2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should actually move this to conda install instead of pip to have more reliable/reproducible solves.
jupyterlab/environment.yaml
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am happy to investigate to find out why we need to revert this, if it was not in the deployed ja.quansight most likely it was to not include anything wasn't necessary to run jhub-apps
@@ -2,6 +2,9 @@ | |||
set -euo pipefail | |||
set -x | |||
|
|||
# install classic notebook extensions | |||
jupyter nbextension enable --py widgetsnbextension --sys-prefix |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same for this, it is for old jlab extensions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I understand where this change is coming from, but let's first investigate the root cause of any issues we may have seen.
@aktech I would love to understand the root cause. This was just an attempt to make jhub-apps run. If we can figure out what is going on without reverting to older packages, that is better. |
Reference Issues or PRs
What does this implement/fix?
Put a
x
in the boxes that applyTesting
Documentation
Access-centered content checklist
Text styling
H1
or#
in markdown).Non-text content
Any other comments?