Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync docker files with what is deployed to ja.quansight.dev #109

Closed
wants to merge 10 commits into from

Conversation

dcmcand
Copy link
Contributor

@dcmcand dcmcand commented Jan 12, 2024

Reference Issues or PRs

What does this implement/fix?

Put a x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features not to work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe):

Testing

  • Did you test the pull request locally?
  • Did you add new tests?

Documentation

Access-centered content checklist

Text styling

  • The content is written with plain language (where relevant).
  • If there are headers, they use the proper header tags (with only one level-one header: H1 or # in markdown).
  • All links describe where they link to (for example, check the Nebari website).
  • This content adheres to the Nebari style guides.

Non-text content

  • All content is represented as text (for example, images need alt text, and videos need captions or descriptive transcripts).
  • If there are emojis, there are not more than three in a row.
  • Don't use flashing GIFs or videos.
  • If the content were to be read as plain text, it still makes sense, and no information is missing.

Any other comments?

@dcmcand dcmcand requested review from dharhas and aktech January 12, 2024 21:12
@@ -14,4 +14,4 @@ dependencies:
- pip:
- nebari-jupyterhub-theme
- python-keycloak==0.26.1
- jhub-apps==2024.1.2
- jhub-apps==2024.1.2
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should actually move this to conda install instead of pip to have more reliable/reproducible solves.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am happy to investigate to find out why we need to revert this, if it was not in the deployed ja.quansight most likely it was to not include anything wasn't necessary to run jhub-apps

@@ -2,6 +2,9 @@
set -euo pipefail
set -x

# install classic notebook extensions
jupyter nbextension enable --py widgetsnbextension --sys-prefix
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same for this, it is for old jlab extensions

Copy link
Member

@aktech aktech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understand where this change is coming from, but let's first investigate the root cause of any issues we may have seen.

@dcmcand
Copy link
Contributor Author

dcmcand commented Jan 15, 2024

@aktech I would love to understand the root cause. This was just an attempt to make jhub-apps run. If we can figure out what is going on without reverting to older packages, that is better.

@dcmcand dcmcand closed this Jan 18, 2024
@dcmcand dcmcand deleted the dcmcand-jhub-4 branch January 18, 2024 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants