Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade JupyterHub to 5.0.0b2 #145

Merged
merged 2 commits into from
May 20, 2024
Merged

Upgrade JupyterHub to 5.0.0b2 #145

merged 2 commits into from
May 20, 2024

Conversation

krassowski
Copy link
Member

@krassowski krassowski commented May 14, 2024

Reference Issues or PRs

What does this implement/fix?

Put a x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features not to work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe):

Testing

  • Did you test the pull request locally?
  • Did you add new tests?

Documentation

Access-centered content checklist

Text styling

  • The content is written with plain language (where relevant).
  • If there are headers, they use the proper header tags (with only one level-one header: H1 or # in markdown).
  • All links describe where they link to (for example, check the Nebari website).
  • This content adheres to the Nebari style guides.

Non-text content

  • All content is represented as text (for example, images need alt text, and videos need captions or descriptive transcripts).
  • If there are emojis, there are not more than three in a row.
  • Don't use flashing GIFs or videos.
  • If the content were to be read as plain text, it still makes sense, and no information is missing.

Any other comments?

@krassowski krassowski marked this pull request as ready for review May 16, 2024 18:40
@aktech
Copy link
Member

aktech commented May 20, 2024

Looks good, there are some conflicts though.

@aktech aktech merged commit c18e714 into main May 20, 2024
11 checks passed
@aktech aktech deleted the jhub-5.0.0b2 branch May 20, 2024 16:09
@krassowski krassowski mentioned this pull request May 27, 2024
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants