Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add docs for profile_options #559

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

Adam-D-Lewis
Copy link
Member

Reference Issues or PRs

See nebari-dev/nebari#2937 for more context
Should be merged after nebari-dev/nebari#2937

What does this implement/fix?

Put a x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features not to work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe):

Testing

  • Did you test the pull request locally?
  • Did you add new tests?

Documentation

Access-centered content checklist

Text styling

  • The content is written with plain language (where relevant).
  • If there are headers, they use the proper header tags (with only one level-one header: H1 or # in markdown).
  • All links describe where they link to (for example, check the Nebari website).
  • This content adheres to the Nebari style guides.

Non-text content

  • All content is represented as text (for example, images need alt text, and videos need captions or descriptive transcripts).
  • If there are emojis, there are not more than three in a row.
  • Don't use flashing GIFs or videos.
  • If the content were to be read as plain text, it still makes sense, and no information is missing.

Any other comments?

@Adam-D-Lewis Adam-D-Lewis requested a review from aktech February 5, 2025 05:08
Copy link

netlify bot commented Feb 5, 2025

Deploy Preview for nebari-docs ready!

Name Link
🔨 Latest commit 2e269f7
🔍 Latest deploy log https://app.netlify.com/sites/nebari-docs/deploys/67aa8f917f740f00080fb3bb
😎 Deploy Preview https://deploy-preview-559--nebari-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Adam-D-Lewis Adam-D-Lewis requested a review from aktech February 10, 2025 23:49
@Adam-D-Lewis
Copy link
Member Author

Adam-D-Lewis commented Feb 17, 2025

From @aktech

To make profile_options fully compatible with jhub-apps server options we would need to change the UI in jhub-apps and use the newly added profile options, but since that's beyond the scope of this PR, its not a blocker.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Todo 📬
Development

Successfully merging this pull request may close these issues.

2 participants