Add GCP support #11
Merged
Add GCP support #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcelovilla
commented
May 10, 2024
src/nebari_plugin_self_registration/terraform/modules/self-registration/main.tf
Show resolved
Hide resolved
kenafoster
requested changes
May 14, 2024
src/nebari_plugin_self_registration/terraform/modules/self-registration/main.tf
Show resolved
Hide resolved
kenafoster
requested changes
May 17, 2024
There was a problem hiding this comment.
Looks good but before merging, could you increment 0.0.8 to 0.0.9 in a couple places:
__version__ in src/nebari_plugin_self_registration/__about__.py
appVersion in src/nebari_plugin_self_registration/terraform/modules/self-registration/chart/Chart.yaml
Shouldn't need to increment the helm chart (or change default docker image) since this doesn't touch either of those
kenafoster
approved these changes
May 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, this plugin can be deployed only in AWS because the affinity node selector keys (here and here) are hard-coded to what AWS EKS expects.
This PR adds
cloud_providerto the Terraform variables so the correct key can be selected depending on whether Nebari is being deployed to AWS or GCP.Related Issue
Motivation and Context
This change is required to be able to deploy the self-registration plugin in GCP.
How Has This Been Tested?
This has been tested by deploying a Nebari instance frome scratch in both AWS and GCP.
Screenshots (if appropriate):