Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin docker base image. Add setuptools for pkg_resources module #23

Merged
merged 5 commits into from
Oct 24, 2024

Conversation

kenafoster
Copy link
Contributor

@kenafoster kenafoster commented Oct 11, 2024

Reference Issues or PRs

the newly built default container image fails to start with `ImportError: No module named pkg_resources .
Initial research indicated that this module is deprecated and not installed by default in Python 3.12. Our Dockerfile starts FROM python:3.12 - as it turns out, the specific image that that tag points to used to include the module, but it has since been updated and apparently no longer includes it.

This PR does two things:

  • Explicitly installs the needed package
  • Pins the Dockerfile base image to a specific SHA so that similar issues won't occur in future

What does this implement/fix?

Put a x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features not to work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe):

Testing

  • Did you test the pull request locally?
  • Did you add new tests?

Documentation

N/A - there is no functional change here

Access-centered content checklist

Text styling

  • The content is written with plain language (where relevant).
  • If there are headers, they use the proper header tags (with only one level-one header: H1 or # in markdown).
  • All links describe where they link to (for example, check the Nebari website).
  • This content adheres to the Nebari style guides.

Non-text content

  • All content is represented as text (for example, images need alt text, and videos need captions or descriptive transcripts).
  • If there are emojis, there are not more than three in a row.
  • Don't use flashing GIFs or videos.
  • If the content were to be read as plain text, it still makes sense, and no information is missing.

Any other comments?

@kenafoster kenafoster changed the title WIP - Pin docker base image. Add setuptools for pkg_resources module Pin docker base image. Add setuptools for pkg_resources module Oct 15, 2024
@aktech
Copy link
Member

aktech commented Oct 16, 2024

Looks good to me other that a couple of minor comments.

@kenafoster kenafoster requested a review from aktech October 23, 2024 18:53
@aktech aktech merged commit fdb77c3 into main Oct 24, 2024
1 check passed
@aktech aktech deleted the fix-base-img branch October 24, 2024 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants