Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TST: playwright test for dask gateway #1987

Closed
wants to merge 14 commits into from

Conversation

fangchenli
Copy link
Member

@fangchenli fangchenli commented Sep 6, 2023

Reference Issues or PRs

close #1971

What does this implement/fix?

Put a x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features not to work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe):

Testing

  • Did you test the pull request locally?
  • Did you add new tests?

Any other comments?

requires #1996 and #2027 first.

Moving this from e2e to integration requires modification to CI. I'll keep it in e2e for this PR and address the CI changes in a separate PR.

@pavithraes
Copy link
Member

From today's chat: we need to move the files to test_integration -- it's not running in CI yet but in-progress

@pavithraes pavithraes added the project: JATIC Work item needed for the JATIC project label Sep 8, 2023
@fangchenli fangchenli marked this pull request as ready for review September 22, 2023 18:46
@fangchenli fangchenli marked this pull request as draft September 24, 2023 18:55
@dcmcand
Copy link
Contributor

dcmcand commented Mar 13, 2024

@marcelovilla can you take a look at this PR and see if you can pick it up?

@marcelovilla
Copy link
Member

I'll go ahead and close this draft PR as it has not seen any recent activity. I agree testing dask-gateway functionality is important and we'll work on implementing it using the dask API rather than Playwright.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
project: JATIC Work item needed for the JATIC project
Projects
Status: Done 💪🏾
Development

Successfully merging this pull request may close these issues.

Write playwright test for dask-gateway
4 participants