Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: move conda build test to seperate job #2073

Merged
merged 8 commits into from
Oct 18, 2023

Conversation

fangchenli
Copy link
Member

@fangchenli fangchenli commented Oct 17, 2023

Reference Issues or PRs

xref: #1128

What does this implement/fix?

Put a x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features not to work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe):

Testing

  • Did you test the pull request locally?
  • Did you add new tests?

Any other comments?

Since nebari does not have non-python extensions, its wheels, and sdists are identical for different Python versions. So it's not necessary to run conda build test in all unit tests jobs. In fact, most of the time spent in unit tests is from the conda build test.

In this PR, I moved the conda build test to a separate job. Combine with #2071, the runtime of unit tests jobs reduced from 30+min to ~2min.

Note: merge before #2071.

@fangchenli fangchenli marked this pull request as ready for review October 17, 2023 07:10
Copy link
Member

@iameskild iameskild left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense. Initially I wanted it part of the pytest suite but I now end up skipping that test unless I explicit update the package dependencies.

Thanks for all the recent clean up 💯

@fangchenli fangchenli merged commit ee1b4c9 into nebari-dev:develop Oct 18, 2023
@fangchenli fangchenli deleted the test-conda-build branch October 18, 2023 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

2 participants