Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove kbatch, prefect and clearml #2101

Merged
merged 3 commits into from
Nov 13, 2023
Merged

Remove kbatch, prefect and clearml #2101

merged 3 commits into from
Nov 13, 2023

Conversation

iameskild
Copy link
Member

Reference Issues or PRs

Closes #1217

What does this implement/fix?

Put a x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features not to work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe):

Testing

  • Did you test the pull request locally?
  • Did you add new tests?

Any other comments?

@iameskild iameskild added this to the 2023.11.1 milestone Nov 8, 2023
@iameskild iameskild added area: dependencies 📦 All things dependencies type: deprecation ⚰️ Deprecating a feature labels Nov 8, 2023
@iameskild iameskild requested review from costrouc and dcmcand November 9, 2023 00:33
Copy link
Contributor

@dcmcand dcmcand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

upgrade.py still says that they are depreciated and will be removed in the next release. Should that be editted now since it is out of date?

@dcmcand dcmcand added the needs: changes 🧱 Review completed - some changes are needed before merging label Nov 11, 2023
@iameskild
Copy link
Member Author

@dcmcand when they run the nebari upgrade command, the user will be, among other things, presented with messages that we may want them to be aware of. I believe we should keep those messages since they might still be helpful to read for folks upgrading from an older version of Nebari to this latest version.

@iameskild iameskild merged commit 0e23ed4 into develop Nov 13, 2023
26 checks passed
@iameskild iameskild deleted the remove_old_apps branch November 13, 2023 16:15
@iameskild iameskild added status: approved 💪🏾 This PR has been reviewed and approved for merge and removed needs: changes 🧱 Review completed - some changes are needed before merging labels Nov 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: dependencies 📦 All things dependencies status: approved 💪🏾 This PR has been reviewed and approved for merge type: deprecation ⚰️ Deprecating a feature
Projects
Development

Successfully merging this pull request may close these issues.

Remove ClearML, Prefect and kbatch as core services
2 participants