Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLN: cleanup typing and typing import in init #2107

Merged
merged 1 commit into from
Nov 13, 2023
Merged

CLN: cleanup typing and typing import in init #2107

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions src/_nebari/subcommands/init.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
import os
import pathlib
import re
import typing
from typing import Optional

import questionary
import rich
Expand Down Expand Up @@ -84,17 +84,17 @@ class GitRepoEnum(str, enum.Enum):
class InitInputs(schema.Base):
cloud_provider: ProviderEnum = ProviderEnum.local
project_name: schema.project_name_pydantic = ""
domain_name: typing.Optional[str] = None
namespace: typing.Optional[schema.namespace_pydantic] = "dev"
domain_name: Optional[str] = None
namespace: Optional[schema.namespace_pydantic] = "dev"
auth_provider: AuthenticationEnum = AuthenticationEnum.password
auth_auto_provision: bool = False
repository: typing.Optional[schema.github_url_pydantic] = None
repository: Optional[schema.github_url_pydantic] = None
repository_auto_provision: bool = False
ci_provider: CiEnum = CiEnum.none
terraform_state: TerraformStateEnum = TerraformStateEnum.remote
kubernetes_version: typing.Union[str, None] = None
region: typing.Union[str, None] = None
ssl_cert_email: typing.Union[schema.email_pydantic, None] = None
kubernetes_version: Optional[str] = None
region: Optional[str] = None
ssl_cert_email: Optional[schema.email_pydantic] = None
disable_prompt: bool = False
output: pathlib.Path = pathlib.Path("nebari-config.yaml")

Expand Down Expand Up @@ -490,7 +490,7 @@ def init(
"Project name must (1) consist of only letters, numbers, hyphens, and underscores, (2) begin and end with a letter, and (3) contain between 3 and 16 characters.",
),
),
domain_name: typing.Optional[str] = typer.Option(
domain_name: Optional[str] = typer.Option(
None,
"--domain-name",
"--domain",
Expand Down
Loading