Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to configure default settings for JupyterLab (overrides.json) #2249

Merged
merged 7 commits into from
Feb 19, 2024

Conversation

krassowski
Copy link
Member

@krassowski krassowski commented Feb 15, 2024

Reference Issues or PRs

Closes #2247

What does this implement/fix?

Put a x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features not to work as expected)
  • Documentation Update: Document default_settings for jupyterlab nebari-docs#407
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe):

Testing

  • Did you test the pull request locally?
    No, I could not setup nebari locally due to Error: client rate limiter Wait returned an error: context deadline exceeded error
  • Did you add new tests?
    Yes, I added a new config yaml file for happy path verifying that jupyterlab.default_settings does not error out, and an end-to-end test

Any other comments?

Copy link
Member

@aktech aktech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good to me! 🎉

@aktech aktech merged commit 872f7bf into nebari-dev:develop Feb 19, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

[ENH] - Allow configuring jupyter_server_config.py and overrides.json from config file
2 participants