Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update CURRENT_RELEASE for 2024.3.2 release #2324

Merged
merged 5 commits into from
Mar 14, 2024
Merged

update CURRENT_RELEASE for 2024.3.2 release #2324

merged 5 commits into from
Mar 14, 2024

Conversation

Adam-D-Lewis
Copy link
Member

@Adam-D-Lewis Adam-D-Lewis commented Mar 14, 2024 •
edited
Loading

Reference Issues or PRs

What does this implement/fix?

Put a x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features not to work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe): for 2024.3.2 release

Testing

  • Did you test the pull request locally?
  • Did you add new tests?

Any other comments?

@Adam-D-Lewis Adam-D-Lewis changed the title update CURRENT_RELEASE for 2024.3.2 release update CURRENT_RELEASE for 2024.3.2 release [WIP] Mar 14, 2024
@Adam-D-Lewis Adam-D-Lewis changed the title update CURRENT_RELEASE for 2024.3.2 release [WIP] update CURRENT_RELEASE for 2024.3.2 release Mar 14, 2024
marcelovilla
marcelovilla requested changes Mar 14, 2024
View reviewed changes
RELEASE.md Outdated
@@ -9,7 +9,19 @@ This file is copied to nebari-dev/nebari-docs using a GitHub Action. -->

---

## Upcoming Release

## Release 2024.3.1 - March 14, 2024
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Adam-D-Lewis it should be 2024.3.2 here

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah, good catch

RELEASE.md Outdated
* add upgrade step by @Adam-D-Lewis in https://github.com/nebari-dev/nebari/pull/2318


**Full Changelog**: https://github.com/nebari-dev/nebari/compare/2024.3.1...2024.3.2rc1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd have the changelog point to the difference between the official releases instead of having it compare against an RC.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah, good catch

@Adam-D-Lewis Adam-D-Lewis merged commit f73ad97 into develop Mar 14, 2024
26 checks passed
@Adam-D-Lewis Adam-D-Lewis deleted the 2024.3.2-constants-update branch March 14, 2024 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcelovilla marcelovilla marcelovilla approved these changes

Assignees
No one assigned
Labels
None yet
Projects
🪴 Nebari Project Management
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Adam-D-Lewis @marcelovilla