Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix loki gateway url when deployed on non-dev namespace #2327

Merged
merged 3 commits into from
Mar 18, 2024

Conversation

aktech
Copy link
Member

@aktech aktech commented Mar 15, 2024

Reference Issues or PRs

It was accidentally assumed that Nebari will always be deployed on "dev" namespace, hence the constructed loki gateway url was not correct for non dev namespaces. This PR makes sure to incorporate namespace in gateway url.

What does this implement/fix?

Put a x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features not to work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe):

Testing

  • Did you test the pull request locally?
  • Did you add new tests?

Any other comments?

@aktech aktech added this to the 2024.3.2 milestone Mar 15, 2024
@aktech aktech force-pushed the loki-gateway-namespace branch from 9cb7b25 to 142a217 Compare March 15, 2024 13:32
@dcmcand dcmcand merged commit 13923e4 into develop Mar 18, 2024
27 checks passed
@dcmcand dcmcand deleted the loki-gateway-namespace branch March 18, 2024 15:22
@viniciusdc viniciusdc modified the milestones: 2024.3.2, 2024.3.3 Mar 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

3 participants