Fix loki gateway url when deployed on non-dev namespace #2327
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues or PRs
It was accidentally assumed that Nebari will always be deployed on "dev" namespace, hence the constructed loki gateway url was not correct for non dev namespaces. This PR makes sure to incorporate namespace in gateway url.
What does this implement/fix?
Put a
x
in the boxes that applyTesting
Any other comments?