add full names for cloud providers in guided init #2375
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues or PRs
Fixes #1708
PR #1744 was made for this before and @iameskild had described a good solution, but the difficulties faced last time arose due to the fact that there's a pydantic root validator in place which then doesn't allow
inputs.cloud_provider
to store full cloud provider names outright. The feature can be implemented by simply using a new variable to hold the inputs from the user and then still passing the accepted enum vals on toinputs.cloud_provider
.It's a very very minor change!
What does this implement/fix?
Put a
x
in the boxes that applyTesting
Any other comments?