Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add full names for cloud providers in guided init #2375

Merged

Conversation

exitflynn
Copy link
Contributor

@exitflynn exitflynn commented Apr 1, 2024

Reference Issues or PRs

Fixes #1708
PR #1744 was made for this before and @iameskild had described a good solution, but the difficulties faced last time arose due to the fact that there's a pydantic root validator in place which then doesn't allow inputs.cloud_provider to store full cloud provider names outright. The feature can be implemented by simply using a new variable to hold the inputs from the user and then still passing the accepted enum vals on to inputs.cloud_provider.
It's a very very minor change!

What does this implement/fix?

Put a x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features not to work as expected)
  • Documentation Update
  • [ x ] Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe):

Testing

  • [ x ] Did you test the pull request locally?
  • Did you add new tests?

Any other comments?

Copy link
Member

@marcelovilla marcelovilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @exitflynn for this contribution! 🚀

@marcelovilla
Copy link
Member

@exitflynn local integration tests are failing but it's unrelated the changes in this PR. Once we have solved that, I'll merge it.

@marcelovilla marcelovilla merged commit 97c5991 into nebari-dev:develop Apr 4, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

[ENH] - Use human-readable cloud providers during guided init
2 participants