-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add cloud provider deployment status badges to README.md #2407
Conversation
Ready for review! |
This is nice, thanks, @Adam-D-Lewis. I don't see any problems with integrating this right away, but I am curious if we want to first make the DO and Azure tests pass again. Also, I noticed that the badge for DO says GCP in there because our DO tests have the same name as the GCP one in the workflow file 🤣
|
This PR will fix that naming issue. I think it'll only show up on that preview page after merge though. |
I say we merge without fixing. It'll give us motivation to fix those others soon. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good to me, thanks @Adam-D-Lewis
Reference Issues or PRs
You can see the new badges at https://github.com/nebari-dev/nebari/tree/depl-badges
What does this implement/fix?
Put a
x
in the boxes that applyTesting
Any other comments?