Fix converted init command in guided init #2666
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues or PRs
Closes #2664
What does this implement/fix?
Put a
x
in the boxes that applyTesting
How to test this PR?
Run
nebari init --guided-init
and answer the prompts as following:You should see a properly rendered init command at the end, just like:
Any other comments?
I've refactored the logic to include options passed as integers (i.e.
--explicit
) and to properly check whether values are empty. This was failing before when not passing a specific k8s version and accepting the default—the resulting command would just have an empty value for the--kubernetes-version
resulting in a failed deployment if copied and ran.