Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/node group sa main part #183

Merged
merged 22 commits into from
Feb 11, 2025
Merged

Conversation

negrovalar
Copy link
Collaborator

Following up on the previous PR (#156
) I split it into two parts - soperator module and main part.
This is the main part. Please merge it after the soperator part - #182.
And please run all available auto-tests.

@malibora
Copy link
Collaborator

malibora commented Feb 3, 2025

@negrovalar why should we merge only after soperator pr? There shouldnt be any connection between the two, right?

@negrovalar
Copy link
Collaborator Author

Correct, no dependency on soperator module. You can merge it at your convenience.

@negrovalar negrovalar had a problem deploying to project-e00pjzzrtk1fs3yavy February 5, 2025 11:05 — with GitHub Actions Error
@negrovalar negrovalar had a problem deploying to project-e00pjzzrtk1fs3yavy February 5, 2025 11:05 — with GitHub Actions Failure
@negrovalar negrovalar had a problem deploying to project-e00pjzzrtk1fs3yavy February 5, 2025 11:05 — with GitHub Actions Error
@negrovalar negrovalar had a problem deploying to project-e00pjzzrtk1fs3yavy February 5, 2025 11:05 — with GitHub Actions Error
@negrovalar negrovalar had a problem deploying to project-e00pjzzrtk1fs3yavy February 5, 2025 11:07 — with GitHub Actions Failure
@malibora
Copy link
Collaborator

malibora commented Feb 5, 2025

@negrovalar pls run "terraform fmt -recursive" in hte solution so that the tests can pass

@negrovalar
Copy link
Collaborator Author

@malibora done, please check

@negrovalar negrovalar had a problem deploying to project-e00pjzzrtk1fs3yavy February 5, 2025 12:05 — with GitHub Actions Error
@negrovalar negrovalar had a problem deploying to project-e00pjzzrtk1fs3yavy February 5, 2025 12:05 — with GitHub Actions Failure
@negrovalar negrovalar had a problem deploying to project-e00pjzzrtk1fs3yavy February 5, 2025 12:05 — with GitHub Actions Error
@negrovalar negrovalar had a problem deploying to project-e00pjzzrtk1fs3yavy February 5, 2025 12:05 — with GitHub Actions Error
@malibora malibora requested a review from d3vil-st as a code owner February 10, 2025 09:42
@malibora malibora had a problem deploying to project-e00pjzzrtk1fs3yavy February 10, 2025 09:42 — with GitHub Actions Failure
@malibora malibora had a problem deploying to project-e00pjzzrtk1fs3yavy February 10, 2025 09:42 — with GitHub Actions Failure
@malibora malibora had a problem deploying to project-e00pjzzrtk1fs3yavy February 10, 2025 09:42 — with GitHub Actions Error
@malibora malibora had a problem deploying to project-e00pjzzrtk1fs3yavy February 10, 2025 09:42 — with GitHub Actions Error
@malibora malibora had a problem deploying to project-e00pjzzrtk1fs3yavy February 10, 2025 09:42 — with GitHub Actions Error
@malibora malibora had a problem deploying to project-e00pjzzrtk1fs3yavy February 10, 2025 15:44 — with GitHub Actions Failure
@malibora malibora had a problem deploying to project-e00pjzzrtk1fs3yavy February 11, 2025 09:48 — with GitHub Actions Failure
@malibora malibora had a problem deploying to project-e00pjzzrtk1fs3yavy February 11, 2025 09:48 — with GitHub Actions Error
@malibora malibora had a problem deploying to project-e00pjzzrtk1fs3yavy February 11, 2025 09:48 — with GitHub Actions Error
@malibora malibora had a problem deploying to project-e00pjzzrtk1fs3yavy February 11, 2025 09:48 — with GitHub Actions Error
@malibora malibora had a problem deploying to project-e00pjzzrtk1fs3yavy February 11, 2025 09:48 — with GitHub Actions Error
@malibora malibora had a problem deploying to project-e00pjzzrtk1fs3yavy February 11, 2025 10:04 — with GitHub Actions Failure
@malibora
Copy link
Collaborator

malibora commented Feb 11, 2025

@negrovalar we got a new error:
image

I think the reason is that tests run k8s-training and k8s-inference in parallel so that's why service account already exists.

Additional, the script needs to be idempotent even with its self, can you pls add a random sufix so that this works? You can use the one from locals, as we do for other resources:

release-suffix = random_string.random.result

…ebius-solution-library into feature/node-group-sa_main_part

merge terraform.yml changes
@negrovalar
Copy link
Collaborator Author

@malibora thanks for the great advice - I added randomness into SA name.

@negrovalar negrovalar temporarily deployed to project-e00pjzzrtk1fs3yavy February 11, 2025 19:45 — with GitHub Actions Inactive
@negrovalar negrovalar temporarily deployed to project-e00pjzzrtk1fs3yavy February 11, 2025 19:45 — with GitHub Actions Inactive
@negrovalar negrovalar had a problem deploying to project-e00pjzzrtk1fs3yavy February 11, 2025 19:45 — with GitHub Actions Failure
@negrovalar negrovalar had a problem deploying to project-e00pjzzrtk1fs3yavy February 11, 2025 19:45 — with GitHub Actions Failure
@negrovalar negrovalar had a problem deploying to project-e00pjzzrtk1fs3yavy February 11, 2025 19:45 — with GitHub Actions Error
@negrovalar negrovalar had a problem deploying to project-e00pjzzrtk1fs3yavy February 11, 2025 20:50 — with GitHub Actions Failure
@negrovalar negrovalar had a problem deploying to project-e00pjzzrtk1fs3yavy February 11, 2025 20:55 — with GitHub Actions Error
@negrovalar negrovalar had a problem deploying to project-e00pjzzrtk1fs3yavy February 11, 2025 20:55 — with GitHub Actions Failure
@negrovalar negrovalar had a problem deploying to project-e00pjzzrtk1fs3yavy February 11, 2025 20:55 — with GitHub Actions Error
@negrovalar negrovalar had a problem deploying to project-e00pjzzrtk1fs3yavy February 11, 2025 20:57 — with GitHub Actions Failure
@malibora malibora merged commit f2c6fa7 into main Feb 11, 2025
2 of 6 checks passed
@malibora malibora deleted the feature/node-group-sa_main_part branch February 11, 2025 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants