-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/node group sa main part #183
Conversation
@negrovalar why should we merge only after soperator pr? There shouldnt be any connection between the two, right? |
Correct, no dependency on soperator module. You can merge it at your convenience. |
@negrovalar pls run "terraform fmt -recursive" in hte solution so that the tests can pass |
@malibora done, please check |
@negrovalar we got a new error: I think the reason is that tests run k8s-training and k8s-inference in parallel so that's why service account already exists. Additional, the script needs to be idempotent even with its self, can you pls add a random sufix so that this works? You can use the one from locals, as we do for other resources:
|
…ebius-solution-library into feature/node-group-sa_main_part merge terraform.yml changes
@malibora thanks for the great advice - I added randomness into SA name. |
Following up on the previous PR (#156
) I split it into two parts - soperator module and main part.
This is the main part. Please merge it after the soperator part - #182.
And please run all available auto-tests.