forked from solidusio/solidus
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[pull] main from solidusio:main #390
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix property destroy - use destroy instead of discard
Also shorten the admin tailwind watcher to be just `admin`.
Co-Authored-By: Elia Schito <[email protected]>
Waiting for ViewComponent/view_component#1934 to be released.
[Admin] Introduce base Index Component
Avoid env variables that seem to not work properly and bump the ruby version.
Add Rails main branch to Circle CI test matrix
Restore coverage tracking
Make it easier to see the error in the RSpec report when running multiple subframeworks in the same job. Previously it required scrolling inside a long output.
…i-runs Separate subframeworks CI runs
In environment expecting precompiled assets `Rails.application.assets` is `nil` and we should fall back on checking the manifest.
…ing-with-precompiled-assets Fix the check on select2 translations asset existence
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )