[pull] main from solidusio:main #404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
The form for creating a new refund reason opens in a modal by leveraging Turbo frames.
This commit completes the process for managing the creation of a new refund reason. Failures update the form in the existing modal with the appropriate error messages, while successful creations update the current page with a Turbo stream refresh and remove the form modal.
This new method allows the order to ask the coupon promotion handler whether an order can be modified with a promotion code.
Rather than directly referencing the Spree::Promotion ActiveRecord model, we ask the coupon code handler.
The core coupon promotion handler now has this method, so the null promotion handler needs it, too.
The four promotion handlers in core have two different methods to set them into motion. Cart, Shipping, and Page use #activate, but Coupon uses #apply. We only need one null promotion handler, and since we just want it to return the unchanged promotion, we just alias.
This new Turbo frame will be filled with the modal for editing the tax category.
The component renders the edit form inside a modal on top of the tax categories list, inside a Turbo frame.
This completes the feature for editing an existing tax category.
This allows us to have our own assets in our controllers.
Promotions don't really have any CSS other than the one for the promotion/edit page. So we only include the CSS there.
This moves those templates, views, and JS files that are necessary for the promotion admin to function to the legacy_promotions gem.
I need to move some of SolidusAdmin's specs into solidus_legacy_promotions. When doing that, it's necessary to require these, so it'd be nice if they lived in `lib/`.
This change introduces a new boolean configuration on the `BatchAction` struct that would allow users of the `UI::Table` component to specify if a batch action requires confirmation. This change enables this new behaviour on the products index batch actions as a proof of concept. Co-authored-by: Kendra Riga <[email protected]> Co-authored-by: Cameron Day <[email protected]>
This change adds proper pluralization in the confirm dialog for the resource being modified. Previously the dialog always used the plural version of the resource.
There is no usecase for selecting from one theme.
…cessary Do not show theme selector if only one theme is configured
[admin] fix docs links in README
Move promotion admin assets
Make SolidusAdmin's testing support code require-able
…-batch-action-confirmation [Admin] Add the ability to configure batch action confirmation
Let promotion handler decide whether it can add a coupon to an order
pull
bot
added
⤵️ pull
and removed
changelog:repository
changelog:solidus_backend
changelog:solidus_core
changelog:solidus_admin
labels
We need to always add routing proxies so our partials work in the context of other engines.
…path Add routes proxy to locale selection path helper
It would be helpful to be able to add shipping methods in the new admin, even though the new views are not migrated yet. This change renames the actions method to page_actions to get that. Co-authored-by: Harmony Bouvier <[email protected]>
In ESLint v9 the flat config is default, but we can change the default back to the old one. See: eslint/eslint#18287
…-new-shipping-method-page-action Show the page action for creating a new shipping method
…reason [Admin] Create new Refund Reasons
[Admin] Add Update Tax Category feature
fix(CI): Set ESLINT_USE_FLAT_CONFIG=false
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )