[pull] main from solidusio:main #409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
With a properly configured promotion system, we don't need a special "shipping" promotion handler. This moves the shipping-specific promotion handling into the solidus_legacy_promotions gem.
The new promotion system does not distinguish between shipping promotions and other promotions, and there is no need for a dedicated shipping promotion handler class in the public API for the promotion configuration. Deprecate it.
This extension point has duplication when used, so we're renaming it to `Spree::Config.promotions.order_adjuster_class`. This describes better what it does.
Rename Spree::Config.promotions.promotion_adjuster_class
…g-to-legacy-promotions Move shipping promotion handling to legacy promotions
Spree::OrderContents interacts heavily with the current promotion system. This adds a new `Spree::SimpleOrderContents` class that we can use once all the core functionality and specs for the legacy promotion system are migrated to `solidus_legacy_promotions`. We're keeping `Spree::OrderContents` though, with the intention of moving it to `solidus_legacy_promotions` in the future.
There were two uncovered lines, and this adds coverage for those lines.
This adds a subscriber that removes all connected order promotions upon emptying the order. A future commit will emit the event instead of directly removing the join table records.
This is where it belongs.
Create Spree::SimpleOrderContents
…-event Clear order promotions in Omnes event
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )