Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The init can select the selector element in a context dom node passed by a parameter #30

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

livike
Copy link

@livike livike commented Jun 19, 2017

First of all thanks for the nice emoji picker. It's just what I needed.
Hovewer i neede a little extension and for this i created this PR.
In my project i need to construct a DOM node before the document object is created. In this case the wdtEmojiBundle.init did not find the element I wanted to add the picker.
I extended the function with a new parameter that accepts the context dom node.
For standard use, when the context is a document object, the parameter is not passed and the context is set to a document.

I had some issues with a gulp build, so mazbe this PR will be not accettable. Can you please provide some instructions how you want gulp to be runned?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant