Pass PID list into wmic query to speed things up on Windows. #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not sure why these tests are failing. After some investigation, it doesn't seem to be related to my changes. |
|
@szikszail I still have no idea why the unit tests were failing here. Maybe things are better now and I could merge develop back into my branch to give things a shot. This is something I can try and look at in a few weeks when I have a bit more free time. Otherwise, maybe @neekey can manually fire off another run of the CI pipelines to see if things will pass now? |
smcpeck
changed the title
|
This is very useful and works fine, should be merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is definitely a hack that only works when querying by PID, which is my use case. It'll partially address #60 and #68.
It sped things up on Windows from 19 seconds to 0.25 seconds. So it definitely works. Surely, it would be great if someone takes this concept and fills it out to handle other use cases.