Merge pull request #79 from nelsonjchen/clippy_apr_2021

Clippy and Rollup Fixes April 2021

src/main.rs

@@ -16,7 +16,7 @@ fn main() -> Result<(), error::Error> {
     env_logger::init();
 
     let matches = App::new("speedtest-rs")
-        .version(&crate_version!()[..])
+        .version(crate_version!())
         .about("Command line interface for testing internet bandwidth using speedtest.net.")
         .arg(
             Arg::with_name("no-download")

src/speedtest.rs

@@ -129,7 +129,7 @@ pub fn get_best_server_based_on_latency(
         let latency = latency_measurements
             .iter()
             .fold(Duration::new(0, 0), |a, &i| a + i)
-            / ((latency_measurements.iter().count() as u32) * 2);
+            / ((latency_measurements.len() as u32) * 2);
         info!("Trip calculated to {} ms", latency.as_millis());
 
         if latency < fastest_latency {

src/speedtest_config.rs

@@ -84,6 +84,7 @@ impl SpeedTestConfig {
             .attribute("ignoreids")
             .ok_or(Error::ConfigParseError)?
             .split(',')
+            .filter(|s| !s.is_empty())
             .map(|s| s.parse::<u32>())
             .collect::<Result<Vec<u32>, _>>()?;