Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No submodule #464

Merged
merged 5 commits into from
Aug 24, 2024
Merged

No submodule #464

merged 5 commits into from
Aug 24, 2024

Conversation

chenzhitong
Copy link
Member

@chenzhitong chenzhitong commented Aug 23, 2024

Remove git submodule, change to NuGet back.

  • Remove .gitmodules
  • Remove submodule from a workflow
  • Modify .csproj to use NuGet instead of submodule
  • Temporarily roll back some of the referenced versions (may need to be changed back in a later version)
    • Remove Neo.Extensions
    • Neo.Plugins.RpcServer -> Neo.Plugins
    • Neo.Plugins.DBFTPlugin.DBFTPlugin -> Neo.Consensus.DBFTPlugin
    • Neo.Plugins.DBFTPlugin.Settings -> Neo.Consensus.Settings
    • Neo.Plugins.RpcServer.RpcException -> Neo.Plugins.RpcException
    • engine.FeeConsumed -> engine.GasConsumed
    • Neo.Extensions.ByteExtensions -> Neo.Helper
  • Formatting modified files

Note:
Some versions of Nuget's references are 3.7.5

  • Neo.Consensus.DBFT
  • Neo.Plugins.RpcServer
  • Neo.Cryptography.MPT
  • Neo.Network.RPC.RpcClient

Some versions of Nuget's references are 3.7.6

  • Neo

@chenzhitong
Copy link
Member Author

@cschuchardt88 Please review

src/bctklib/bctklib.csproj Show resolved Hide resolved
src/Directory.Build.props Show resolved Hide resolved
@cschuchardt88 cschuchardt88 merged commit 067d818 into neo-project:master Aug 24, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants