Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[**Part-2] Add github Release Workflow #3360

Draft
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

cschuchardt88
Copy link
Member

@cschuchardt88 cschuchardt88 commented Jun 27, 2024

Description

Just have to Draft a Release and release generates the zip binary files for plugins.

Please Merge wtih:

Change Log

  • Added Plugins zip files to release

image

Type of change

  • Optimization (the change is only an optimization)
  • Style (the change is only a code style for better maintenance or standard purpose)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

In my github repo

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@cschuchardt88 cschuchardt88 marked this pull request as draft July 1, 2024 03:26
@cschuchardt88 cschuchardt88 added Blocked This issue can't be worked at the moment and removed Waiting for Review labels Jul 1, 2024
@Jim8y Jim8y added Waiting for Review and removed Blocked This issue can't be worked at the moment labels Jul 4, 2024
@superboyiii
Copy link
Member

superboyiii commented Aug 12, 2024

OracleService.zip
SQLiteWallet.zip
@cschuchardt88 Just take care of these 2 plugins, they have their own dependencies. You can unzip and take a look. They can be got only by dotnet publish but not dotnet build. SQLiteWallet is more special, it needs global install sqlite, or got it from runtime file and put it into CLI root path. Otherwise SQLiteWallet will not work. I still can't find a good way to handle, so I just manually put sqlite runtime file into release package for WINx64, OSXx64 and LINUXx64.

@cschuchardt88 cschuchardt88 added Backlog Backlog issues and PRs and removed Work in Progress labels Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backlog Backlog issues and PRs GitHub Workflow
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants