[Core] rename hasher #3651
Merged
[Core] rename hasher #3651
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nan01ab
reviewed
Jan 1, 2025
|
|
||
| namespace Neo.Cryptography | ||
| { | ||
| public enum HashAlgorithmType : byte |
|
|
nan01ab
reviewed
Jan 2, 2025
|
|
||
| namespace Neo.Cryptography | ||
| { | ||
| public enum HashAlgorithm : byte |
There was a problem hiding this comment.
Maybe add an implicit operator here(it converts Hasher to HashAlgorithm)?
shargon
reviewed
Jan 2, 2025
| /// <returns>The ECDSA signature for the specified message.</returns> | ||
| public static byte[] Sign(byte[] message, byte[] priKey, ECC.ECCurve ecCurve = null, Hasher hasher = Hasher.SHA256) | ||
| public static byte[] Sign(byte[] message, byte[] priKey, ECC.ECCurve ecCurve = null, HashAlgorithm hashAlgorithm = HashAlgorithm.SHA256) |
There was a problem hiding this comment.
Only change the argument name for obsolete?
| namespace Neo.Cryptography | ||
| { | ||
| /// <summary> | ||
| /// Represents hash function identifiers supported by ECDSA message signature and verification. | ||
| /// </summary> | ||
| [Obsolete("Use HashAlgorithm instead")] |
There was a problem hiding this comment.
I prefer rename the enum instead of duplicate all the methods
There was a problem hiding this comment.
You have to, those methods are public, previously our principle is duplicate a new one and obsolete old one before remove it, at least previouly we deal with public methods that way.
shargon
reviewed
Jan 3, 2025
shargon
approved these changes
Jan 3, 2025
nan01ab
approved these changes
Jan 3, 2025
vncoelho
approved these changes
Jan 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As is pointed out by @Hecate2 and @cschuchardt88 #3633 (comment), the name Hasher is ambiguous and improper, thus having this pr to rename it to
HashAlgorithmType.Fixes # #3633 (comment)
Type of change
Checklist: