Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow ReadOnlySpan in RIPEMD160 #3659

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Allow ReadOnlySpan in RIPEMD160 #3659

wants to merge 4 commits into from

Conversation

shargon
Copy link
Member

@shargon shargon commented Jan 8, 2025

Description

Close #1760

Type of change

  • Optimization (the change is only an optimization)
  • Style (the change is only a code style for better maintenance or standard purpose)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

  • TestRIPEMD160

Test Configuration:

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Copy link
Contributor

@roman-khimov roman-khimov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any performance tests for this?

@shargon shargon changed the title Close https://github.com/neo-project/neo/issues/1760 Allow ReadOnlySpan in RIPEMD160 Jan 8, 2025
@shargon
Copy link
Member Author

shargon commented Jan 8, 2025

Any performance tests for this?

#1760 (comment)

@nan01ab
Copy link
Contributor

nan01ab commented Jan 8, 2025

There is a bug in RIPEMD160Managed. Fixed in #3661


var output = new byte[ripemd160.HashSize / 8];
if (!ripemd160.TryComputeHash(value, output.AsSpan(), out _))
throw new Exception();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
throw new Exception();
throw new CryptographicException();

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update RIPEMD160Managed to work w/ Spans
5 participants