Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix + in json #3663

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

fix + in json #3663

wants to merge 3 commits into from

Conversation

shargon
Copy link
Member

@shargon shargon commented Jan 8, 2025

Description

Fix #2612
Based on https://github.com/neo-project/neo/pull/2050/files

Type of change

  • Optimization (the change is only an optimization)
  • Style (the change is only a code style for better maintenance or standard purpose)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

  • JsonTest_Object

Test Configuration:

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

static JToken()
{
var textSettings = new TextEncoderSettings(UnicodeRanges.BasicLatin);
textSettings.AllowCharacter('+');
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@neo-project/core Anyone can help me why is not working unless I use unsafe relaxing?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

JavaScriptEncoder encoder = JavaScriptEncoder.UnsafeRelaxedJsonEscaping;

OR

[Fact]
        public void Ctor_WithTextEncoderSettings()
        {
            // Arrange
            var filter = new TextEncoderSettings();
            filter.AllowCharacters('a', 'b');
            filter.AllowCharacters('\0', '&', '\uFFFF', 'd');

            JavaScriptEncoder encoder = JavaScriptEncoder.Create(filter);

            // Act & assert
            Assert.Equal("a", encoder.Encode("a"));
            Assert.Equal("b", encoder.Encode("b"));
            Assert.Equal(@"\u0063", encoder.Encode("c"));
            Assert.Equal("d", encoder.Encode("d"));
            Assert.Equal(@"\u0000", encoder.Encode("\0")); // we still always encode control chars
            Assert.Equal(@"\u0026", encoder.Encode("&")); // we still always encode HTML-special chars
            Assert.Equal(@"\uFFFF", encoder.Encode("\uFFFF")); // we still always encode non-chars and other forbidden chars
        }

@roman-khimov
Copy link
Contributor

This can lead to some state diff, needs to be checked.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

'+' still replaced by \u002B
4 participants