Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy the runtimes files for rocksdbsharp #3666

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

vncoelho
Copy link
Member

@vncoelho vncoelho commented Jan 9, 2025

Applying @cschuchardt88 suggestion closes #3419

Copy link
Member

@shargon shargon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes mandatory the plugins, we should try to fix it with dependencies. But it's ok if we create a issue for fix this in the future

@vncoelho
Copy link
Member Author

vncoelho commented Jan 9, 2025

This makes mandatory the plugins, we should try to fix it with dependencies. But it's ok if we create a issue for fix this in the future

I understand.
That is true as well.

@vncoelho
Copy link
Member Author

vncoelho commented Jan 9, 2025

@shargon , maybe let's plan another solution that do that during Plugin publish instead.

@cschuchardt88
Copy link
Member

#3665 fixes this issue

@vncoelho
Copy link
Member Author

vncoelho commented Jan 9, 2025

#3665 fixes this issue

they are different things and different strategies as well.
Here we solve for local building and etc...
The other approach is focussed on the Release itself as I as see.

@cschuchardt88
Copy link
Member

cschuchardt88 commented Jan 11, 2025

#3665 fixes this issue

they are different things and different strategies as well. Here we solve for local building and etc... The other approach is focussed on the Release itself as I as see.

It fixes everything.

  • Local Development
  • Github Release
  • Github workflow tests for all OS, windows, linux, macos
  • github docker release
  • dev containers
  • dotnet publish, build

@@ -33,6 +33,7 @@
<ProjectReference Include="..\Neo.ConsoleService\Neo.ConsoleService.csproj" />
<ProjectReference Include="..\Neo.Extensions\Neo.Extensions.csproj" />
<ProjectReference Include="..\Neo\Neo.csproj" />
<ProjectReference Include="..\Plugins\RocksDBStore\RocksDBStore.csproj" />
</ItemGroup>

Copy link
Member

@cschuchardt88 cschuchardt88 Jan 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to move the RocksDBStore to the plugins folder or else it will be in with neo-cli binaries and to many copies will be on disk.

Something like this for post build

<Target Name="MoveRocksDbForBuild" BeforeTargets="PostBuildEvent">
    <Move SourceFiles="$(OutputPath)/RocksDBStore.dll" DestinationFolder="$(OutDir)/Plugins/RocksDBStore" />
</Target>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RockDb FileNotFoundException
5 participants