-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Copy the runtimes files for rocksdbsharp #3666
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This makes mandatory the plugins, we should try to fix it with dependencies. But it's ok if we create a issue for fix this in the future
I understand. |
@shargon , maybe let's plan another solution that do that during Plugin publish instead. |
#3665 fixes this issue |
they are different things and different strategies as well. |
It fixes everything.
|
@@ -33,6 +33,7 @@ | |||
<ProjectReference Include="..\Neo.ConsoleService\Neo.ConsoleService.csproj" /> | |||
<ProjectReference Include="..\Neo.Extensions\Neo.Extensions.csproj" /> | |||
<ProjectReference Include="..\Neo\Neo.csproj" /> | |||
<ProjectReference Include="..\Plugins\RocksDBStore\RocksDBStore.csproj" /> | |||
</ItemGroup> | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You need to move the RocksDBStore
to the plugins folder or else it will be in with neo-cli
binaries and to many copies will be on disk.
Something like this for post build
<Target Name="MoveRocksDbForBuild" BeforeTargets="PostBuildEvent">
<Move SourceFiles="$(OutputPath)/RocksDBStore.dll" DestinationFolder="$(OutDir)/Plugins/RocksDBStore" />
</Target>
Applying @cschuchardt88 suggestion closes #3419