Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Plugins Output Files #3723

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

cschuchardt88
Copy link
Member

@cschuchardt88 cschuchardt88 commented Feb 7, 2025

Description

As you all know the output directory for the plugins included all dependencies. Which is very hard to clean up. Well @Jim8y your prayers have been answered. This PR fixed that issue and only outputs the *.dll, *.json and *.pdb files. Plugins will no longer require the dependencies in their directories. The dependencies have been included in Neo.CLI.csproj file.

@vncoelho
These changes may affect you.

Out Directory now

image
image
image

Type of change

  • Optimization (the change is only an optimization)
  • Style (the change is only a code style for better maintenance or standard purpose)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

  • On my local computer and environment.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

<PackageReference Include="rocksdb" Version="9.7.3.54622" />
<PackageReference Include="NeoFS.API" Version="3.5.0" />
<PackageReference Include="System.Text.RegularExpressions" Version="4.3.1" />
<PackageReference Include="Microsoft.EntityFrameworkCore.Sqlite" Version="9.0.1" />
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are included because they're dependencies for plugins.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can't add all the dependencies, this break the plugin's idea... we need a different solution

Copy link
Member Author

@cschuchardt88 cschuchardt88 Feb 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We already have see below in neo-cli that is a dependency for RcpServer to work. I can just remove these lines and deployment would be the same.

  <ItemGroup>
    <FrameworkReference Include="Microsoft.AspNetCore.App" />
  </ItemGroup>

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can't add all the dependencies, this break the plugin's idea... we need a different solution

I am also in agreement with @shargon

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well Ill plugins class so this isn't an issue.

tests/Directory.Build.props Outdated Show resolved Hide resolved
tests/Neo.VM.Tests/Neo.VM.Tests.csproj Show resolved Hide resolved
Jim8y
Jim8y previously approved these changes Feb 13, 2025
@vncoelho
Copy link
Member

I will test asap in 3 days

Jim8y
Jim8y previously approved these changes Feb 15, 2025
nan01ab
nan01ab previously approved these changes Feb 15, 2025
@cschuchardt88 cschuchardt88 dismissed stale reviews from nan01ab and Jim8y via 44cce8c February 15, 2025 17:11
Copy link
Member

@vncoelho vncoelho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not liking this solution very much.

I prefer the original way with deps in the folder. You can easily filter that for the release which is what we do on NeoResearch release.

@cschuchardt88
Copy link
Member Author

I am not liking this solution very much.

I prefer the original way with deps in the folder. You can easily filter that for the release which is what we do on NeoResearch release.

Doesn't deploy all the deps, for the library

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants