-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fix
] Plugins Output Files
#3723
base: master
Are you sure you want to change the base?
[Fix
] Plugins Output Files
#3723
Conversation
<PackageReference Include="rocksdb" Version="9.7.3.54622" /> | ||
<PackageReference Include="NeoFS.API" Version="3.5.0" /> | ||
<PackageReference Include="System.Text.RegularExpressions" Version="4.3.1" /> | ||
<PackageReference Include="Microsoft.EntityFrameworkCore.Sqlite" Version="9.0.1" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are included because they're dependencies for plugins
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can't add all the dependencies, this break the plugin's idea... we need a different solution
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We already have see below in neo-cli
that is a dependency for RcpServer
to work. I can just remove these lines and deployment would be the same.
<ItemGroup>
<FrameworkReference Include="Microsoft.AspNetCore.App" />
</ItemGroup>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can't add all the dependencies, this break the plugin's idea... we need a different solution
I am also in agreement with @shargon
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well Ill plugins
class so this isn't an issue.
I will test asap in 3 days |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not liking this solution very much.
I prefer the original way with deps in the folder. You can easily filter that for the release which is what we do on NeoResearch release.
Doesn't deploy all the deps, for the library |
Description
As you all know the
output
directory for the plugins included all dependencies. Which is very hard to clean up. Well @Jim8y your prayers have been answered. This PR fixed that issue and only outputs the*.dll
,*.json
and*.pdb
files. Plugins will no longer require the dependencies in their directories. The dependencies have been included inNeo.CLI.csproj
file.@vncoelho
These changes may affect you.
Out Directory now
Type of change
How Has This Been Tested?
Checklist: