Updated KeyBuilder Fast Access

[cschuchardt88]

Description

Fixed with Disposing MemoryStream on ToArray(). Made a lot faster as well. Enforced Overflows and other lengths.

Type of change

• Optimization (the change is only an optimization)
• Style (the change is only a code style for better maintenance or standard purpose)
• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update

How Has This Been Tested?

• Unit Testing

Checklist:

• My code follows the style guidelines of this project
• I have performed a self-review of my code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes
• Any dependent changes have been merged and published in downstream modules

[nan01ab]

Any benchmark data?

[shargon]

Increase it?

[cschuchardt88]

why? Is not >= or what do you mean

[shargon]

I mean, increase the array instead of throw an error

[cschuchardt88]

Since the Length is passed in, we need to enforce that length. 99% of the time we know the length up front?

[shargon]

Otherwise is not a hint, and is not working as before, it should not happen so it won't have any impact in the performance

[cschuchardt88]

I had @superboyiii test this on mainnet and testnet, no key is bigger than 64 bytes. So we need to enforce. If you want bigger key you must know the size before hand.

#3705 (review)

[shargon]

It haven't got any sense to me, throw an exception when is possible to increase the buffer, usability vs optimization? Could you clarify why we should not increase the buffer and preserve the previous behavior?

[cschuchardt88]

I already did state that. You pass in a LENGTH. What's the point of doing that if it not enforced? Im sick of everything being programmed around these bugs. It needs to stop. Have some discipline.