Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix async node iterator #800

Merged

Conversation

mariusconjeaud
Copy link
Collaborator

Closes #798

@mariusconjeaud mariusconjeaud requested review from robsdedude and removed request for robsdedude May 27, 2024 13:19
Copy link

codecov bot commented May 27, 2024

Codecov Report

Attention: Patch coverage is 91.66667% with 2 lines in your changes are missing coverage. Please review.

Please upload report for BASE (rc/5.3.1@b32e169). Learn more about missing BASE report.

Files Patch % Lines
neomodel/async_/match.py 83.33% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             rc/5.3.1     #800   +/-   ##
===========================================
  Coverage            ?   91.38%           
===========================================
  Files               ?       34           
  Lines               ?     4574           
  Branches            ?        0           
===========================================
  Hits                ?     4180           
  Misses              ?      394           
  Partials            ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented May 28, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@mariusconjeaud mariusconjeaud merged commit 5f58cc4 into rc/5.3.1 May 28, 2024
33 checks passed
@mariusconjeaud mariusconjeaud deleted the 798-async-iterating-over-nodes-is-not-working branch May 28, 2024 13:39
@mariusconjeaud mariusconjeaud linked an issue May 28, 2024 that may be closed by this pull request
@mariusconjeaud mariusconjeaud added this to the 5.3.1 milestone May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

async iterating over nodes is not working
1 participant