Skip to content

Moves syntax errors to the semantic analysis worker #1538

Moves syntax errors to the semantic analysis worker

Moves syntax errors to the semantic analysis worker #1538

Triggered via pull request December 31, 2024 09:18
Status Failure
Total duration 10m 3s
Artifacts 1

ci.yaml

on: pull_request
Run eslint and check formatting
2m 29s
Run eslint and check formatting
Unit tests
2m 2s
Unit tests
E2E tests
9m 53s
E2E tests
Fit to window
Zoom out
Zoom in

Annotations

10 errors and 3 warnings
src/tests/syntaxValidation/semanticValidation.test.ts > Semantic validation spec > Semantic errors work using empty preparser options. Like CYPHER <rest of query: packages/language-support/src/tests/syntaxValidation/semanticValidation.test.ts#L108
AssertionError: expected [ { severity: 1, …(3) }, …(1) ] to deeply equal [ { …(4) }, { …(4) } ] - Expected + Received Array [ Object { "message": "Query cannot conclude with MATCH (must be a RETURN clause, a FINISH clause, an update clause, a unit subquery call, or a procedure call with no YIELD).", "offsets": Object { - "end": 16, + "end": 17, "start": 7, }, "range": Object { "end": Object { - "character": 16, + "character": 17, "line": 0, }, "start": Object { "character": 7, "line": 0, }, }, "severity": 1, }, Object { "message": "Variable `n` not defined", "offsets": Object { "end": 62, "start": 61, }, "range": Object { "end": Object { "character": 44, "line": 1, }, "start": Object { "character": 43, "line": 1, }, }, "severity": 1, }, ] ❯ src/tests/syntaxValidation/semanticValidation.test.ts:108:47
src/tests/syntaxValidation/semanticValidation.test.ts > Semantic validation spec > Semantic errors work using both version syntax and key-value syntax for preparser options. Like CYPHER <version> <option> = <value>: packages/language-support/src/tests/syntaxValidation/semanticValidation.test.ts#L153
AssertionError: expected [ { severity: 1, …(3) }, …(1) ] to deeply equal [ { …(4) }, { …(4) } ] - Expected + Received Array [ Object { "message": "Query cannot conclude with MATCH (must be a RETURN clause, a FINISH clause, an update clause, a unit subquery call, or a procedure call with no YIELD).", "offsets": Object { - "end": 54, + "end": 55, "start": 45, }, "range": Object { "end": Object { - "character": 54, + "character": 55, "line": 0, }, "start": Object { "character": 45, "line": 0, }, }, "severity": 1, }, Object { "message": "Variable `n` not defined", "offsets": Object { "end": 115, "start": 114, }, "range": Object { "end": Object { "character": 59, "line": 1, }, "start": Object { "character": 58, "line": 1, }, }, "severity": 1, }, ] ❯ src/tests/syntaxValidation/semanticValidation.test.ts:153:47
src/tests/syntaxValidation/semanticValidation.test.ts > Semantic validation spec > Semantic errors work with preparser option CYPHER <option> = <value>: packages/language-support/src/tests/syntaxValidation/semanticValidation.test.ts#L198
AssertionError: expected [ { severity: 1, …(3) }, …(1) ] to deeply equal [ { …(4) }, { …(4) } ] - Expected + Received Array [ Object { "message": "Query cannot conclude with MATCH (must be a RETURN clause, a FINISH clause, an update clause, a unit subquery call, or a procedure call with no YIELD).", "offsets": Object { - "end": 53, + "end": 54, "start": 44, }, "range": Object { "end": Object { - "character": 53, + "character": 54, "line": 0, }, "start": Object { "character": 44, "line": 0, }, }, "severity": 1, }, Object { "message": "Variable `n` not defined", "offsets": Object { "end": 112, "start": 111, }, "range": Object { "end": Object { "character": 57, "line": 1, }, "start": Object { "character": 56, "line": 1, }, }, "severity": 1, }, ] ❯ src/tests/syntaxValidation/semanticValidation.test.ts:198:47
src/tests/syntaxValidation/semanticValidation.test.ts > Semantic validation spec > Semantic errors work with preparser option CYPHER <version>: packages/language-support/src/tests/syntaxValidation/semanticValidation.test.ts#L243
AssertionError: expected [ { severity: 1, …(3) }, …(1) ] to deeply equal [ { …(4) }, { …(4) } ] - Expected + Received Array [ Object { "message": "Query cannot conclude with MATCH (must be a RETURN clause, a FINISH clause, an update clause, a unit subquery call, or a procedure call with no YIELD).", "offsets": Object { - "end": 19, + "end": 20, "start": 10, }, "range": Object { "end": Object { - "character": 19, + "character": 20, "line": 0, }, "start": Object { "character": 10, "line": 0, }, }, "severity": 1, }, Object { "message": "Variable `n` not defined", "offsets": Object { "end": 67, "start": 66, }, "range": Object { "end": Object { "character": 46, "line": 1, }, "start": Object { "character": 45, "line": 1, }, }, "severity": 1, }, ] ❯ src/tests/syntaxValidation/semanticValidation.test.ts:243:47
src/tests/syntaxValidation/semanticValidation.test.ts > Semantic validation spec > Semantic errors work when we also have preparser options: packages/language-support/src/tests/syntaxValidation/semanticValidation.test.ts#L288
AssertionError: expected [ { severity: 1, …(3) }, …(1) ] to deeply equal [ { …(4) }, { …(4) } ] - Expected + Received Array [ Object { "message": "Query cannot conclude with MATCH (must be a RETURN clause, a FINISH clause, an update clause, a unit subquery call, or a procedure call with no YIELD).", "offsets": Object { - "end": 17, + "end": 18, "start": 8, }, "range": Object { "end": Object { - "character": 17, + "character": 18, "line": 0, }, "start": Object { "character": 8, "line": 0, }, }, "severity": 1, }, Object { "message": "Variable `n` not defined", "offsets": Object { "end": 64, "start": 63, }, "range": Object { "end": Object { "character": 45, "line": 1, }, "start": Object { "character": 44, "line": 1, }, }, "severity": 1, }, ] ❯ src/tests/syntaxValidation/semanticValidation.test.ts:288:47
src/tests/syntaxValidation/syntacticValidation.test.ts > Syntactic validation spec > Syntax validation errors on multiline unfinished string: packages/language-support/src/tests/syntaxValidation/syntacticValidation.test.ts#L632
AssertionError: expected [ { severity: 1, …(3) } ] to deeply equal [ { …(4) } ] - Expected + Received Array [ Object { "message": "Failed to parse string literal. The query must contain an even number of non-escaped quotes.", "offsets": Object { - "end": 37, + "end": 18, "start": 7, }, "range": Object { "end": Object { - "character": 9, - "line": 2, + "character": 18, + "line": 0, }, "start": Object { "character": 7, "line": 0, }, }, "severity": 1, }, ] ❯ src/tests/syntaxValidation/syntacticValidation.test.ts:632:7
src/tests/syntaxValidation/syntacticValidation.test.ts > Syntactic validation spec > Syntax validation errors on multiline unfinished property keys: packages/language-support/src/tests/syntaxValidation/syntacticValidation.test.ts#L667
AssertionError: expected [ { severity: 1, …(3) } ] to deeply equal [ { …(4) } ] - Expected + Received Array [ Object { "message": "Invalid input '`': expected an identifier or '}'", "offsets": Object { - "end": 49, + "end": 19, "start": 8, }, "range": Object { "end": Object { - "character": 17, - "line": 3, + "character": 19, + "line": 0, }, "start": Object { "character": 8, "line": 0, }, }, "severity": 1, }, ] ❯ src/tests/syntaxValidation/syntacticValidation.test.ts:667:7
src/tests/syntaxValidation/syntacticValidation.test.ts > Syntactic validation spec > Syntax validation errors on unfinished multiline comment: packages/language-support/src/tests/syntaxValidation/syntacticValidation.test.ts#L700
AssertionError: expected [ { severity: 1, …(3) } ] to deeply equal [ { …(4) } ] - Expected + Received Array [ Object { - "message": "Unfinished comment", + "message": "Failed to parse comment. A comment starting on `/*` must have a closing `*/`.", "offsets": Object { - "end": 34, + "end": 2, "start": 0, }, "range": Object { "end": Object { - "character": 13, - "line": 2, + "character": 2, + "line": 0, }, "start": Object { "character": 0, "line": 0, }, }, "severity": 1, }, ] ❯ src/tests/syntaxValidation/syntacticValidation.test.ts:700:7
src/tests/syntaxValidation/syntacticValidation.test.ts > Syntactic validation spec > Syntax validation errors on an expected procedure name: packages/language-support/src/tests/syntaxValidation/syntacticValidation.test.ts#L760
AssertionError: expected [ { severity: 1, …(3) } ] to deeply equal [ { …(4) } ] - Expected + Received Array [ Object { - "message": "Expected any of '{', '(' or a procedure name", + "message": "Invalid input ',': expected an identifier, '(' or '{'", "offsets": Object { - "end": 6, + "end": 9, "start": 5, }, "range": Object { "end": Object { - "character": 6, + "character": 9, "line": 0, }, "start": Object { "character": 5, "line": 0, }, }, "severity": 1, }, ] ❯ src/tests/syntaxValidation/syntacticValidation.test.ts:760:7
src/tests/syntaxValidation/syntacticValidation.test.ts > Syntactic validation spec > Syntax validation errors on an expected map literal: packages/language-support/src/tests/syntaxValidation/syntacticValidation.test.ts#L789
AssertionError: expected [ { severity: 1, …(3) } ] to deeply equal [ { …(4) } ] - Expected + Received Array [ Object { "message": "Invalid input '[': expected an identifier or '}'", "offsets": Object { - "end": 13, + "end": 14, "start": 8, }, "range": Object { "end": Object { - "character": 13, + "character": 14, "line": 0, }, "start": Object { "character": 8, "line": 0, }, }, "severity": 1, }, ] ❯ src/tests/syntaxValidation/syntacticValidation.test.ts:789:7
Unit tests
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
Run eslint and check formatting
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
E2E tests
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636

Artifacts

Produced during runtime
Name Size
playwright-report
642 KB