Fixes memory leak in the React editor #113
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was reproducible when making the web repl grow gradually. For example by copy pasting the same example query back to back:
The memory consumption in Firefox jumped from 25 MiB to 400 MiB, I have even seen GiB if you keep on writing queries.
After the change:
Why
I don't have a clear idea yet why this was happening, but I suspect we are holding the old string in the
onChange
, so we are just preventing the GC from cleaning old values of the editor?