Fixes bug with '(' showing for allShortestPaths, ANY, etc #115
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Solves a bug where we get
allShortestPaths '('
instead ofallShortestPaths
as completion.Why
This was introduced when the errors code started to use c3 for giving better error messages. The reason is the c3 engine keeps a static copy of the ATN cached for all the instances, that depends only on the name of the parser, but not the ignoredTokens:
The ATN transitions get computed having into account the ignored tokens:
There's a race condition between the errors code (which doesn't configure ignored tokens to get brackets in the error messages :
Expected one of (, [, etc
) and the completions engine (which just suggests keywords).