Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make editor history controlled and onExecute reactive #136

Merged
merged 5 commits into from
Nov 10, 2023
Merged

Make editor history controlled and onExecute reactive #136

merged 5 commits into from
Nov 10, 2023

Conversation

OskarDamkjaer
Copy link
Collaborator

We need more control of what is in the editor history in query, so I've moved it to be externally controlled. If we see the need for uncontrolled history, we can add an uncontrolledHistory prop to make onExecute push to history again.

ncordon
ncordon approved these changes Nov 9, 2023
View reviewed changes
Copy link
Collaborator

@ncordon ncordon left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. You are just missing doing npx changeset version I think

@OskarDamkjaer OskarDamkjaer merged commit 37e41a4 into main Nov 10, 2023
3 checks passed
@OskarDamkjaer OskarDamkjaer deleted the reactive_on_exec branch November 10, 2023 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ncordon ncordon ncordon approved these changes

Assignees

@ncordon ncordon

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@OskarDamkjaer @ncordon