Fix incorrect completions when identifier overlaps with keyword #138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ncordon
approved these changes
Nov 21, 2023
ncordon
reviewed
Nov 21, 2023
Comment on lines
+1
to
+5
| --- | ||
| '@neo4j-cypher/language-support': patch | ||
| --- | ||
|
|
||
| Fix incorrect completions when identifier overlaps with keyword |
There was a problem hiding this comment.
Only comment is this should not be included in the pr I think and we should bunch them up before doing a release? Rather than creating this patch.
There was a problem hiding this comment.
This will not trigger a release, only add a changeset right? It's nice to add the changeset relating to the commit at the same time we do the commit IMO
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have logic for knowing when to complete the next vs current word. Our logic only moved the cursor back for identifier, so it didn't work when there was overlap between identfiers and keywords. For example:
SHOW DATcorrectly suggestsDATABASEbut
SHOW DATAwould not.