Add an ariaLabel prop to CypherEditor #216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 135ffe9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
|
Create changeset
ncordon
approved these changes
May 22, 2024
ncordon
reviewed
May 22, 2024
ncordon
reviewed
May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding an 'ariaLabel' prop to the CyperEditor props so that we can set an aria-label attribute on the codemirror editor.
This uses the contentAttributes facet, which may be extended later to add more DOM attributes, or changed to accept a kvp/Record so that DOM attributes may be fully flexible.
with the
ariaLabelproperty set, we can see the attribute set in the playground:The property is optional, so not setting it should result in the aria-label attribute not being added to the editor:
