Updates grammar and semantic analysis to the LTS version #304
Conversation
|
ncordon
force-pushed
the
update-lts-grammar
branch
from
0228b95 to
d72a794
Compare
modify-semantic-analysis.js
Outdated
|
|
||
| result = result.replace( | ||
| `$rt_exports.main = $rt_export_main;`, | ||
| `export { $rt_export_main as main };`, |
There was a problem hiding this comment.
I'd expected the transpiled code not to need modification and the export { $rt_export_main as main };. I think it's outlined in the docs under Generating a module how to not need/use a main with the phony calls we have now:
By default, you use Java convention with public static main method of the main class specified in configuration. A module will be generated that exports one method called main. If you need to convert a library, don't follow this convention. Instead, create static methods in your main class and annotate them with @JSExport annotation
There was a problem hiding this comment.
If that'd let use get rid of this extra step, it'd help us get closer to automatic publishing + depending on semantic analysis
There was a problem hiding this comment.
Perhaps then we could try
<!-- Whether TeaVM should produce minified JavaScript. Can reduce JavaScript file size more than
two times -->
<minifying>false</minifying>
minifying again? 🤔 I don't remember if why we don't have it on
There was a problem hiding this comment.
No description provided.