Changes param in cmd-parser to take escaped strings too #309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
…main parser does, and modified usage ib parseWrapper to fit
…rized rules are used yet, so I used parameterName["ANY"] for now
anderson4j
force-pushed
the
escapedParam
branch
from
41fec4a to
38948a7
Compare
ncordon
reviewed
Dec 10, 2024
ncordon
approved these changes
Jan 3, 2025
ncordon
reviewed
Jan 3, 2025
| @@ -60,7 +60,7 @@ export class CypherEditorPage { | |||
| } | |||
|
|
|||
| async checkNoNotificationMessage(type: 'error' | 'warning') { | |||
| await this.page.waitForTimeout(3000); | |||
| await this.page.waitForTimeout(1000); | |||
There was a problem hiding this comment.
We haven't found any better alternative than this 😢
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cypher5/25Parser.g4 define
parameter[String paramType]
: DOLLAR parameterName[paramType]
;
parameterName[String paramType]
: (symbolicNameString | UNSIGNED_DECIMAL_INTEGER)
;
In CypherCmdParser.g4 instead we had:
paramsCmd: PARAM paramsArgs?;
paramsArgs: (CLEAR | listCompletionRule | map | lambda);
lambda: unescapedSymbolicNameString EQ GT expression;
So params created with lambda could never be escaped, even though regular parser allows it. this aligns cmd-parser with regular.