Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relints documents when connecting / disconnecting to a database #318

Merged
merged 3 commits into from
Dec 23, 2024

Conversation

ncordon
Copy link
Collaborator

@ncordon ncordon commented Dec 23, 2024

The failing behaviour can be seen in the test added by 706f9ec.

Why

Because if we ask to lint a document when the schema is yet not fetched, we will never see schema dependent errors (non existent labels, deprecation warnings, non existent procedures, etc). This can happen when we open the the editor open with a cypher file when we haven't yet connected to a database.

Conversely, when we disconnect from a database, this should also relint the document.

This will become more relevant when we have several connections and we can be connected to different databases with different procedures / functions, different labels, ...

Copy link

changeset-bot bot commented Dec 23, 2024

⚠️ No Changeset found

Latest commit: e4045ae

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Collaborator

@daveajrussell daveajrussell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense to me 👍

I can see the relint function running (only once) when the schema fetched event fires

@ncordon ncordon merged commit f72a940 into main Dec 23, 2024
4 checks passed
@ncordon ncordon deleted the reload-editor-on-connection branch December 23, 2024 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants