Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating link to operations manual causing broken link #423

Merged
merged 6 commits into from
Feb 7, 2024

Conversation

lidiazuin
Copy link
Contributor

No description provided.

@neo-technology-commit-status-publisher
Copy link
Collaborator

Thanks for the documentation updates.

The preview documentation has now been torn down - reopening this PR will republish it.

Copy link
Contributor

@stefano-ottolenghi stefano-ottolenghi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for looking into this.

Probably also transactions.adoc in the Go manual has a broken link to the home database?

@@ -193,7 +193,7 @@ These are provided as an arbitrary number of callbacks from the 4th function arg

It is recommended to *always specify the database explicitly* with the `neo4j.ExecuteQueryWithDatabase("<dbName>")` callback, even on single-database instances.
This allows the driver to work more efficiently, as it does not have to resolve the home database first.
If no database is given, the link:{neo4j-docs-base-uri}/operations-manual/current/manage-databases/introduction#manage-databases-default[user's home database] is used.
If no database is given, the link:{neo4j-docs-base-uri}/operations-manual/current/database-administration/[user's home database] is used.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This (and all later instances) should include the anchor to the home database section in that page.

@@ -81,7 +81,7 @@ There are two additional boolean methods which act as meta-counters:
## Query execution plan

If you prefix a query with `EXPLAIN`, the server will return the plan it _would_ use to run the query, but will not actually run it.
You can retrieve the plan by calling `ResultSummary.Plan()`, which contains the list of link:{neo4j-docs-base-uri}/cypher-manual/current/execution-plans/operators/[Cypher operators] that would be used to retrieve the result set.
You can retrieve the plan by calling `ResultSummary.Plan()`, which contains the list of link:{neo4j-docs-base-uri}/cypher-manual/current/planning-and-tuning/operators/[Cypher operators] that would be used to retrieve the result set.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's fine to update this link, but it's also important to fix the redirect which is currently in place but broken.

@lidiazuin
Copy link
Contributor Author

Redirects are also being addressed here https://github.com/neo-technology/neo4j-manual-modeling-antora/pull/521

@stefano-ottolenghi stefano-ottolenghi merged commit 155fdc1 into neo4j:dev Feb 7, 2024
5 checks passed
stefano-ottolenghi added a commit that referenced this pull request Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants