Fix JIJ output location, add CoreMod to testproject for testing #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Last commit published: 9f3be3e805818a31a66de9019f941eb14c9c74d8. PR PublishingThe artifacts published by this PR:
Repository DeclarationIn order to use the artifacts published by the PR, add the following repository to your buildscript: repositories {
maven {
name 'Maven for PR #18' // https://github.com/neoforged/ModDevGradle/pull/18
url 'https://prmaven.neoforged.net/ModDevGradle/pr18'
content {
includeModule('net.neoforged.moddev', 'net.neoforged.moddev.gradle.plugin')
includeModule('net.neoforged', 'moddev-gradle')
}
}
} |
Matyrobbrt
requested changes
Jun 14, 2024
src/main/java/net/neoforged/moddevgradle/dsl/NeoForgeExtension.java
Outdated
Show resolved
Hide resolved
src/main/java/net/neoforged/moddevgradle/internal/utils/IdeDetection.java
Outdated
Show resolved
Hide resolved
src/main/java/net/neoforged/moddevgradle/internal/utils/IdeDetection.java
Show resolved
Hide resolved
Technici4n
requested changes
Jun 14, 2024
| * This must be relative to the project directory since we can only set this to the same project-relative | ||
| * directory across all subprojects due to IntelliJ limitations. | ||
| */ | ||
| private static final String JUNIT_GAME_DIR = "build/minecraft-junit"; |
There was a problem hiding this comment.
Shouldn't this be using the project layout instead of hardcoding build/?
| @@ -651,28 +661,48 @@ private void setupTesting(Project project, | |||
|
|
|||
| project.afterEvaluate(p -> { | |||
| // Test tasks don't have a provider-based property for working directory, so we need to afterEvaluate it. | |||
| testTask.configure(task -> task.setWorkingDir(unitTest.getGameDirectory())); | |||
| testTask.configure(task -> task.setWorkingDir(gameDirectory)); | |||
There was a problem hiding this comment.
I think that this part can be removed from afterEvaluate.
| testTask.configure(task -> task.setWorkingDir(unitTest.getGameDirectory())); | ||
| testTask.configure(task -> task.setWorkingDir(gameDirectory)); | ||
|
|
||
| // Write out a separate file that has IDE specific VM args, which include the definition of the output directories. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.