Skip to content

Commit

Permalink
Fix fingerprint model bug and update documentation
Browse files Browse the repository at this point in the history
  • Loading branch information
neomantra committed Jan 26, 2024
1 parent 99ec274 commit de8861b
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 4 deletions.
5 changes: 3 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -96,8 +96,8 @@ Thus, by simply specifying the Device Type name `onload`, we get the Onload capa

If configured with `probe_pps` or `probe_ptp`, this plugin will also detect devices under `/dev/pps*` and `/dev/ptp*`. The will be made available as `pps` and `ptp` device types.

* `<vendor>/pps/<interface>`
* `<vendor>/ptp/<interface>`
* `none/pps/<interface>` : for example `/none/pps/pps0`
* `none/ptp/<interface>` : for example `/none/ptp/ptp1`

## Plugin Configuration

Expand Down Expand Up @@ -209,6 +209,7 @@ Here we are with this same capability for [HashiCorp Nomad](https://www.nomadpro
* [ ] Device Statistics
* [ ] Redis example
* [ ] XDP example
* [ ] Expose Nomad-selected interfaces via environment variables, e.g. how does `device "ptp" {}` become `/dev/ptp1` inside the config?

## Credits and License

Expand Down
2 changes: 1 addition & 1 deletion examples/terraform/sfptpd/main.tf
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ locals {
# device_type = ""
# or picka "pps" or "ptp" device
is_privileged = "false"
device_type = "ptp"
device_type = "none/ptp/ptp0"
}

terraform {
Expand Down
2 changes: 1 addition & 1 deletion internal/onload_device/fingerprint.go
Original file line number Diff line number Diff line change
Expand Up @@ -282,7 +282,7 @@ func (d *OnloadDevicePlugin) deviceGroupFromFingerprintData(groupName string, de
deviceGroup := &device.DeviceGroup{
Vendor: dev.Vendor,
Type: dev.DeviceType,
Name: groupName,
Name: dev.Model,
Devices: devices,
Attributes: map[string]*structs.Attribute{},
}
Expand Down

0 comments on commit de8861b

Please sign in to comment.