Sourcery refactored refactor-generate-features-module branch #30
Conversation
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
| line = re.findall(r'[0-9]+', text) | ||
| return line | ||
| return re.findall(r'[0-9]+', text) |
There was a problem hiding this comment.
Function gather_whole_numbers refactored with the following changes:
- Inline variable that is immediately returned (
inline-immediately-returned-variable)
| score = score * 100 | ||
| score *= 100 |
There was a problem hiding this comment.
Function sentiment_polarity refactored with the following changes:
- Replace assignment with augmented assignment (
aug-assign)
| found_stop_words = [word for _, word in enumerate(word_tokens) | ||
| return [word for _, word in enumerate(word_tokens) | ||
| if word in STOP_WORDS] | ||
| return found_stop_words |
There was a problem hiding this comment.
Function gather_stop_words refactored with the following changes:
- Inline variable that is immediately returned (
inline-immediately-returned-variable)
| for index in range(1): | ||
| for _ in range(1): |
There was a problem hiding this comment.
Function generate_data refactored with the following changes:
- Replace unused for index with underscore (
for-index-underscore)
| for index in range(1): | ||
| for _ in range(1): |
There was a problem hiding this comment.
Function generate_data refactored with the following changes:
- Replace unused for index with underscore (
for-index-underscore)
Sourcery Code Quality Report✅ Merging this PR will increase code quality in the affected files by 0.31%.
Here are some functions in these files that still need a tune-up:
Legend and ExplanationThe emojis denote the absolute quality of the code:
The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request. Please see our documentation here for details on how these metrics are calculated. We are actively working on this report - lots more documentation and extra metrics to come! Let us know what you think of it by mentioning @sourcery-ai in a comment. |
Codecov Report
@@ Coverage Diff @@
## refactor-generate-features-module #30 +/- ##
===================================================================
Coverage 100.00% 100.00%
===================================================================
Files 21 21
Lines 360 358 -2
Branches 51 51
===================================================================
- Hits 360 358 -2
Continue to review full report at Codecov.
|
Branch
refactor-generate-features-modulerefactored by Sourcery.If you're happy with these changes, merge this Pull Request using the Squash and merge strategy.
See our documentation here.
Run Sourcery locally
Reduce the feedback loop during development by using the Sourcery editor plugin:
Review changes via command line
To manually merge these changes, make sure you're on the
refactor-generate-features-modulebranch, then run: