Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sourcery refactored master branch #33

Closed
wants to merge 1 commit into from
Closed

Conversation

sourcery-ai[bot]
Copy link

@sourcery-ai sourcery-ai bot commented Oct 16, 2020

Branch master refactored by Sourcery.

If you're happy with these changes, merge this Pull Request using the Squash and merge strategy.

See our documentation here.

Run Sourcery locally

Reduce the feedback loop during development by using the Sourcery editor plugin:

Review changes via command line

To manually merge these changes, make sure you're on the master branch, then run:

git fetch origin sourcery/master
git merge --ff-only FETCH_HEAD
git reset HEAD^

@sourcery-ai sourcery-ai bot requested a review from neomatrix369 October 16, 2020 12:35
score = score * 100
score *= 100
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Function sentiment_polarity refactored with the following changes:

  • Replace assignment with augmented assignment (aug-assign)

line = re.findall(r'[0-9]+', text)
return line
return re.findall(r'[0-9]+', text)
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Function gather_whole_numbers refactored with the following changes:

  • Inline variable that is immediately returned (inline-immediately-returned-variable)

Comment on lines -18 to -20
found_stop_words = [word for _, word in enumerate(word_tokens)
return [word for _, word in enumerate(word_tokens)
if word in STOP_WORDS]
return found_stop_words
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Function gather_stop_words refactored with the following changes:

  • Inline variable that is immediately returned (inline-immediately-returned-variable)

for index in range(1):
for _ in range(1):
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Function generate_data refactored with the following changes:

  • Replace unused for index with underscore (for-index-underscore)

for index in range(1):
for _ in range(1):
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Function generate_data refactored with the following changes:

  • Replace unused for index with underscore (for-index-underscore)

@sourcery-ai
Copy link
Author

sourcery-ai bot commented Oct 16, 2020

Sourcery Code Quality Report

✅  Merging this PR will increase code quality in the affected files by 0.31%.

Quality metrics Before After Change
Complexity 1.00 ⭐ 1.00 ⭐ 0.00
Method Length 35.48 ⭐ 35.10 ⭐ -0.38 👍
Working memory 5.76 ⭐ 5.67 ⭐ -0.09 👍
Quality 87.71% 88.02% 0.31% 👍
Other metrics Before After Change
Lines 205 203 -2
Changed files Quality Before Quality After Quality Change
nlp_profiler/sentiment_polarity.py 85.57% ⭐ 85.63% ⭐ 0.06% 👍
nlp_profiler/granular_features/numbers.py 95.63% ⭐ 96.67% ⭐ 1.04% 👍
nlp_profiler/granular_features/stop_words.py 91.41% ⭐ 92.43% ⭐ 1.02% 👍
slow-tests/performance_tests/test_perf_grammar_check.py 85.30% ⭐ 85.30% ⭐ 0.00%
slow-tests/performance_tests/test_perf_spelling_check.py 85.30% ⭐ 85.30% ⭐ 0.00%

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
slow-tests/performance_tests/test_perf_grammar_check.py test_given_a_text_column_when_profiler_is_applied_with_high_level_analysis_then_it_finishes_quick 2 ⭐ 122 😞 12 😞 60.51% 🙂 Try splitting into smaller methods. Extract out complex expressions
slow-tests/performance_tests/test_perf_spelling_check.py test_given_a_text_column_when_profiler_is_applied_with_high_level_analysis_then_it_finishes_quick 2 ⭐ 122 😞 12 😞 60.51% 🙂 Try splitting into smaller methods. Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Let us know what you think of it by mentioning @sourcery-ai in a comment.

@neomatrix369
Copy link
Owner

Closing now and regenerating PR

@neomatrix369 neomatrix369 deleted the sourcery/master branch October 16, 2020 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve code quality based on report from @sourcery-ai (generate_features.py)
1 participant