feat(neon): Allow getting a &'cx T from a Handle<'cx, JsBox<T>>
#1087
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oh, I like these names! |
dherman
approved these changes
Jan 10, 2025
kjvalencik
force-pushed
the
kv/jsbox-lifetime
branch
from
2c40cf7 to
c0f0442
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #678
I added
Handle<JsBox>::as_innerandJsBox::deref. Let me know if you have preferred names. I was trying to pick reasonable names that didn't conflict with built-in incompatible traits (e.g.,AsRef).This feature is needed for
impl<'cx, T> TryFromJs<'cx> for &'cx RefCell<T>which will allow low boilerplate extractors.