feat(neon): Add extractor for TypedArray #1089
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the
TryIntoJs
implementations forArc
andBox
to free them up for implicitlyBoxed
implementations.In order to maintain the ability to return borrowed buffers (e.g.,
Arc<Vec<u8>>
), I've added extractors for typed arrays. It requires slightly more type noise (e.g.,Uint8Array<Arc<Vec<u8>>
instead ofArc<Vec<u8>>
), but it is more powerful because it will work across all types that areAsRef<[T]>
.The implementation in this PR opts for bespoke
struct
extractors for each of the typed array types (e.g.,Uint8Array
,Int8Array
). The benefits of this approach are the simplicity of implementation and the ability to directly use them as destructor patterns and constructors. The most significant downside is that there's no trait to unify them for generic buffer functions.If we wanted to include a trait for handling these in the future, we could introduce a
TypedArray
extractor and accept that this implementation is distinct from the one in this PR. No breaking change would be necessary.Example Usage